Shared copies display bugs

[Jens]

The GUI of S1/SP has been buggy for a long time. The shared copies display bug is especially confusing.

Initial setup:
- A first two bars event with two C5/E5 chords with different velocities.
- A shared copy of this event is placed at the last position.
- The middle shared copy is created by dragging to the right.

Event/Chord bugs:
1. The score view doesn't display the middle event at all.
2. The current chord is not displayed for the middle event.

Velocity based rectangle selection bug:
1. Last event selection dragged from right to left misses the velocities of the first 2 events.
2. First event selection dragged from left to right misses all velocities and notes.
There's a lot of confusing variety: Selecting the last velocity of the middle event properly selects all notes and velocities. Starting the rectangle selection inside an event might also work. Moving the mouse to the track section after selection suddenly highlights the missing velocities.

Bonus scale based velocity coloring bug:
1. Switching scales and enabling scale based coloring works only for notes and not velocities.
Forcing a redraw by scrolling left/right updates only the velocities that need to be redrawn.

 

[SwitchBack]

I'll have to check but personally I haven't seen unexpected things in this department.

Maybe it's the naming causing confusion? AFAIK 'Shared copies' actually means 'two events sharing the same source material/file', but not necessarily the same portion of that source material. So in effect one event can have say a portion from refrain 1 and the 'shared copy' can have the same portion albeit from refrain 2. That could explain the differences between the two events.

 

[Jens]

SwitchBack, the note editor treats shared copies properly. I change one note and all shared notes are changed as well. Also, look at the second image on the right. In this case, SP selects all shared notes and velocities as expected. Or the current chord at playhead position may not get displayed when it's a shared copy. Why?

 

[SwitchBack]

Well, as is the expression, you present a strong case. But I did want to put out there that with 'shared copies' the emphasis is on 'shared' rather than on 'copies'. Events are windows on a source/file, and moving a window can change the view.